Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: recode and replace the line chart #325

Merged
merged 9 commits into from
Jan 26, 2022
Merged

refactor: recode and replace the line chart #325

merged 9 commits into from
Jan 26, 2022

Conversation

18alantom
Copy link
Member

  • Looks 99% the same.
  • Major difference, loading is instant, unlike the previous line chart which took around a second to render.
  • Minor difference, tooltip looks and behaviour is waayy better.

(not adding gif for suspense)

@18alantom 18alantom merged commit 3007b68 into frappe:master Jan 26, 2022
@18alantom 18alantom deleted the refactor-line-chart branch January 26, 2022 18:53
@18alantom 18alantom mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@18alantom