refactor: inline frappejs code into books #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Closing dropdown on document click * Formatting
* Add error modal * Initialize frappe.error and frappe.events. Code formatting * Fix indentation
- apply formula on server side only if the field is read only - skip applying formula if the value is already set
- Add Tree View
* Added image upload to rest api * Add file-loader and indexEntry * Add file-loader and indexEntry * Added delete file route * Thumbnail creation with imagemagick * Added unauthorized event * Rebase to a new branch * Revert Time.vue * Enable friendly errors plugin
- also trigger ajax events
* Thumbnail creation using Sharp * Cleanup styles and path name * fix webpack config
* Removed redundant files from client folder * removed console statement
refactor: use dedicated class to handle currency
Added options to skipCacheDocument if ever needed
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.5 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.5...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
- for now backwards compatible - will remote T on changing all instances
096dc61 to
f602caf
Compare
2c2c81a to
a1eb699
Compare
This was referenced Jan 21, 2022
This was referenced Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved relevant code from
frappejsintobooks. Used this. There's some stuff included that isn't used inbooks, but I think it may be of use later hence added.This results in a ~57% reduction in the
frappejscode.More context on why: frappe/frappejs#164