Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start setting up error logging #313

Merged
merged 12 commits into from
Jan 28, 2022
Merged

Conversation

18alantom
Copy link
Member

@18alantom 18alantom commented Jan 18, 2022

Something to ease the logging of errors. Primarily:

  • Report Issue button which leads to Github issues.
  • Show toast on error.
  • On clicking the toast, new issue page with error stack, and since intent is to report, send report to frappebooks.com
  • System setting to auto report and hide the errors

closes #296

@18alantom 18alantom marked this pull request as draft January 18, 2022 13:04
@18alantom 18alantom force-pushed the error-handling branch 7 times, most recently from c560936 to ed596e8 Compare January 24, 2022 09:26
@18alantom 18alantom marked this pull request as ready for review January 28, 2022 13:12
@18alantom
Copy link
Member Author

publish.yml script needs to be updated to add error logging creds into builds, will do it in a future commit

@18alantom 18alantom merged commit 31ca138 into frappe:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report an Issue button
1 participant