New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provisions for settings sync #312

Merged

18alantom merged 3 commits into frappe:master from 18alantom:fix-settings-sync

Jan 18, 2022

Member

18alantom commented Jan 18, 2022

Added some provisioning for syncing settings and updating cache in case the settings are fetched from the cache.
Here changes in displayPrecision require a reload to be visible (because of keep-alive components) so a toast is displayed with the Reload action.
Afaik only displayPrecision has an issue will add other syncing mechanisms if required.

18alantom added 3 commits

January 18, 2022 14:01


          feat: allow emitting change from two column form

283237c


          feat: forward change event from setting tabs

98c6b32


          feat: handle change in main settings component

e7ed7ff

- show toast if display precision has changed

18alantom merged commit 526eaf9 into frappe:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet