Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed profit loss report half-yearly filter field #305

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Fixed profit loss report half-yearly filter field #305

merged 2 commits into from
Jan 14, 2022

Conversation

piyushsinghania
Copy link
Contributor

@piyushsinghania piyushsinghania commented Jan 13, 2022 •
edited
Loading

Fixed the erroneous behaviour of half-yearly filter field.
cc: @ankitsinghaniyaz @18alantom

Current behavior -
image

Expected behavior -

1 April 2020 to 31 March 2022 should be like broken into -

April 2020 - Sept 2020
Oct 2020 - March 2021
April 2021 - Sept 2021
Oct 2021 - March 2022

image

@ankitsinghaniyaz
Copy link
Contributor

ankitsinghaniyaz commented Jan 13, 2022 •
edited
Loading

closes #176

@18alantom
Copy link
Member

Merging cause rebase conflicts.

@18alantom 18alantom merged commit 2758580 into frappe:master Jan 14, 2022
@18alantom 18alantom mentioned this pull request Jan 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@18alantom 18alantom 18alantom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piyushsinghania @ankitsinghaniyaz @18alantom