Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build): add upgrade frappejs #301

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Conversation

18alantom
Copy link
Member

@18alantom 18alantom commented Jan 13, 2022

Need to run yarn upgrade frappejs before linking. Not adding this line throws this error:

Error: Rule can only have one resource source (provided resource and test + include + exclude) in {
  "type": "javascript/auto",
  "include": [
    {}
  ],
  "use": []
}

This makes no sense to me cause:

  1. The diff remains the same.
  2. Linking removes the resolved frappejs and sets it to the cloned one.

But it works. I'll check what's actually up later when revamping the build, depending on so many build tools and their millions of moving parts causes an ever-present sense of trepidation.

@18alantom 18alantom merged commit e9369f0 into frappe:master Jan 13, 2022
@18alantom 18alantom deleted the fix-build branch January 13, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant