New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetching fresh document and avoiding cached one to prevent error #299

Merged

18alantom merged 2 commits into frappe:master from piyushsinghania:fix/cache-error

Jan 12, 2022

Contributor

piyushsinghania commented Jan 11, 2022 •

edited by ankitsinghaniyaz

Loading

cc: @ankitsinghaniyaz @18alantom

depends on frappe/frappejs#158

piyushsinghania added 2 commits

January 11, 2022 18:11


          Fetching fresh document and avoiding cached one to prevent error

8fed2a4


          Renamed to skipDocumentCache

a1a28fb

ankitsinghaniyaz requested review from netchampfaris and 18alantom and removed request for netchampfaris

January 12, 2022 05:21

18alantom approved these changes

View reviewed changes

Member

18alantom commented Jan 12, 2022

LGTM, the build is breaking for some unrelated reasons ideally, the cached value should be invalidated and updated, but for now merging this.

18alantom merged commit 80e542f into frappe:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet