Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to view and export GSTR II #298

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

piyushsinghania
Copy link
Contributor

@18alantom
Copy link
Member

@piyushsinghania can you allow edits on this PR. I can't push fixes or resolve rebase conflicts.

Copy link
Member

@18alantom 18alantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine. Just a query:

  • Why doesn't GSTR-1 have csv export?
  • Why doesn't GSTR-2 have json export?

(cc @ankitsinghaniyaz)

@piyushsinghania
Copy link
Contributor Author

I guess this is already enabled? @18alantom can you confirm, or do I need to do something else?
image

@piyushsinghania
Copy link
Contributor Author

Regarding this -

Everything looks fine. Just a query:

  • Why doesn't GSTR-1 have csv export?
  • Why doesn't GSTR-2 have json export?

(cc @ankitsinghaniyaz)

It's actually inspired from EN,
one can directly upload GSTR-1 data as json to GST-portal for filling purposes.
Whereas GSTR-2 is now generated by the GSTR-1 reports filled/submitted by the suppliers and can be availed from GST-portal itself.
Yes, we can add export as csv to GSTR-1 also (It's there in EN). And it can be then raised in a separate PR.

@18alantom

image

@18alantom
Copy link
Member

I guess this is already enabled? @18alantom can you confirm, or do I need to do something else?

I'm unable to push to this PR for some reason 🤨

@18alantom
Copy link
Member

Yes, we can add export as csv to GSTR-1 also (It's there in EN). And it can be then raised in a separate PR.

We'll add it in later then, CSV and JSON for both.

@18alantom
Copy link
Member

Creating a merge commit instead of rebasing cause of rebase conflicts. exports will be pushed through later PRs

@18alantom 18alantom merged commit 7e18dc5 into frappe:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants