-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor currency handling to use pesa #268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6102a9
to
d6ea619
Compare
All builds are gonna fail cause they're dependent on the |
afbcbcf
to
65b1a05
Compare
- number type Float, Int - remove floatPrecision
- add two for SI items
ankitsinghaniyaz
approved these changes
Jan 11, 2022
This was referenced Jan 11, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currency Refactor
PR pertains to refactoring books to use
pesa
to handle monetary calculations.Pesa initialization
"XXX"
code for no currency.Todo List
pesa
methods.Money#store
which will get a precision adjusted decimal string.
Money object.
currency
andinternalPrecision
are available setpesa
onthe global object.
Other Changes
. Validations will be inline, previous change has been removed cause they are called onModel#field#validate(value, doc)
will be called before update inBase.vue
onblur
ring of the input fielddoc.set
.Screen.Recording.2022-01-10.at.13.46.10.mov
Int
andFloat
types now have number inputs,Model#field#minValue
andModel#field#maxValue
can be used to restrict the range.Intl.NumberFormat
FrappeJS: frappe/frappejs#153