Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple payment related fixes #256

Merged
merged 1 commit into from
Nov 25, 2021
Merged

fix: multiple payment related fixes #256

merged 1 commit into from
Nov 25, 2021

Conversation

18alantom
Copy link
Member

  • outstanding amount reset on payment cancel
  • payment reference type is now Select, earlier it was Auto Complete wtf?!
  • map property on select fields for different display values for references to show Invoice and Bill
  • multiple payment validations
  • sensible binding payment and reference amount; changing amount will update ref if it's single
  • filter references by outstanding > 0
    some other stuff I may be missing out

fixes #254

@18alantom
fix: multiple payment related fixes
b8671cb 
- outstanding amount reset on payment cancel
- payment reference type is now select
- map property on select fields for different display values
- multiple payment validations
- sensible binding payment amount and reference amount
@18alantom 18alantom merged commit 24e43d1 into frappe:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update outstanding amount of invoices on cancelling payments.
1 participant
@18alantom