Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor changes and fixes to Payments #236

Merged
merged 5 commits into from
Nov 8, 2021

Conversation

18alantom
Copy link
Member

@18alantom 18alantom commented Nov 5, 2021

  • Handle "Saving..." hang up.
  • Prevent altering Submitted submittable doctypes (such as Payments) from the quick view.
  • Add reversion and ledger link to Payment quick form view.
  • Rename Payment For to Payment References. (∵ the field name shows on error and "Payment For" doesn't show any where, table column names have "Reference" in them so this is less confusing)
  • Make for not mandatory. (∵ deferred to ERPNext functionality)
  • Allow any amount to be set if no reference. (∵ used to set to 0 otherwise)
  • Ref. / Cheque No. is mandatory only if method is not Cash. (∵ Cash Payments may not have a reference)
  • Add migration for the Payment table. (∵ changes in for and referenceId changes) Added this as an exercise.
  • Convert default calling Date to functional defaults. (∵ Default gets set whenever the script is done so table updates sets defaults )
  • Formatting fixes.

Note: SQLite doesn't allow column changes, so table will have to be prestiged even for minor changes like flipping a NOT NULL.

(fixes boolean from previous PR, didn't realize this got added in)

Fixes: #137 #178

Needs frappejs/pull/152 to work.

@18alantom 18alantom changed the title fix: minore changes and fixes to Payments fix: minor changes and fixes to Payments Nov 5, 2021
@18alantom 18alantom marked this pull request as ready for review November 8, 2021 14:12
@18alantom 18alantom merged commit ab97812 into frappe:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always showing "saving"-MacOS 0.0.3-beta.11.76
1 participant