Skip to content

Commit

Permalink
Speedup monomorphic switch type
Browse files Browse the repository at this point in the history
  • Loading branch information
@franz1981
franz1981 committed Jan 15, 2024
1 parent 15bf7c1 commit 72d7483
Show file tree
Hide file tree
Showing 3 changed files with 112 additions and 21 deletions.
123 changes: 105 additions & 18 deletions ...va/io/quarkus/resteasy/reactive/server/runtime/QuarkusResteasyReactiveRequestContext.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,25 @@

public class QuarkusResteasyReactiveRequestContext extends VertxResteasyReactiveRequestContext {

private static final int MATRIX_PARAM_HANDLER = 0;
private static final int SECURITY_CONTEXT_OVERRIDE_HANDLER = 1;
private static final int REST_INITIAL_HANDLER = 2;
private static final int CLASS_ROUTING_HANDLER = 3;
private static final int ABORT_CHAIN_HANDLER = 4;
private static final int NON_BLOCKING_HANDLER = 5;
private static final int BLOCKING_HANDLER = 6;
private static final int RESOURCE_REQUEST_FILTER_HANDLER = 7;
private static final int INPUT_HANDLER = 8;
private static final int REQUEST_DESERIALIZE_HANDLER = 9;
private static final int PARAMETER_HANDLER = 10;
private static final int INSTANCE_HANDLER = 11;
private static final int INVOCATION_HANDLER = 12;
private static final int FIXED_PRODUCES_HANDLER = 13;
private static final int RESPONSE_HANDLER = 14;
private static final int RESPONSE_WRITER_HANDLER = 15;

final CurrentIdentityAssociation association;
private int[] knownHandlerTypeMap;
boolean userSetup = false;

public QuarkusResteasyReactiveRequestContext(Deployment deployment,
Expand Down Expand Up @@ -103,6 +121,19 @@ private <E extends Throwable> RuntimeException sneakyThrow(Throwable e) throws E
throw (E) e;
}

@Override
protected void setHandlers(final ServerRestHandler[] newHandlerChain) {
super.setHandlers(newHandlerChain);
// recompute the known handler type map, trying to avoid reallocating it if possible
var handlers = this.handlers;
var handlerTypePerPosition = (knownHandlerTypeMap == null || handlers.length != knownHandlerTypeMap.length) ?
new int[newHandlerChain.length] : knownHandlerTypeMap;
for (int position = 0; position < handlers.length; position++) {
handlerTypePerPosition[position] = knownTypeIdFor(handlers[position]);
}
this.knownHandlerTypeMap = handlerTypePerPosition;
}

/**
* The implementation looks like it makes no sense, but it in fact does make sense from a performance perspective.
* The idea is to reduce the use instances of megamorphic calls into a series of instance checks and monomorphic calls.
Expand All @@ -113,41 +144,97 @@ private <E extends Throwable> RuntimeException sneakyThrow(Throwable e) throws E
@Override
protected void invokeHandler(int pos) throws Exception {
var handler = handlers[pos];
var handlerType = knownHandlerTypeMap[pos];
switch (handlerType) {
case MATRIX_PARAM_HANDLER:
handler.handle(this);
break;
case SECURITY_CONTEXT_OVERRIDE_HANDLER:
handler.handle(this);
break;
case REST_INITIAL_HANDLER:
handler.handle(this);
break;
case CLASS_ROUTING_HANDLER:
handler.handle(this);
break;
case ABORT_CHAIN_HANDLER:
handler.handle(this);
break;
case NON_BLOCKING_HANDLER:
handler.handle(this);
break;
case BLOCKING_HANDLER:
handler.handle(this);
break;
case RESOURCE_REQUEST_FILTER_HANDLER:
handler.handle(this);
break;
case INPUT_HANDLER:
handler.handle(this);
break;
case REQUEST_DESERIALIZE_HANDLER:
handler.handle(this);
break;
case PARAMETER_HANDLER:
handler.handle(this);
break;
case INSTANCE_HANDLER:
handler.handle(this);
break;
case INVOCATION_HANDLER:
handler.handle(this);
break;
case FIXED_PRODUCES_HANDLER:
handler.handle(this);
break;
case RESPONSE_HANDLER:
handler.handle(this);
break;
case RESPONSE_WRITER_HANDLER:
handler.handle(this);
break;
default:
// megamorphic call for other handlers
handler.handle(this);
}
}

private static int knownTypeIdFor(Object handler) {
if (handler instanceof org.jboss.resteasy.reactive.server.handlers.MatrixParamHandler) {
handler.handle(this);
return MATRIX_PARAM_HANDLER;
} else if (handler instanceof io.quarkus.resteasy.reactive.server.runtime.security.SecurityContextOverrideHandler) {
handler.handle(this);
return SECURITY_CONTEXT_OVERRIDE_HANDLER;
} else if (handler instanceof org.jboss.resteasy.reactive.server.handlers.RestInitialHandler) {
handler.handle(this);
return REST_INITIAL_HANDLER;
} else if (handler instanceof org.jboss.resteasy.reactive.server.handlers.ClassRoutingHandler) {
handler.handle(this);
return CLASS_ROUTING_HANDLER;
} else if (handler instanceof org.jboss.resteasy.reactive.server.handlers.AbortChainHandler) {
handler.handle(this);
return ABORT_CHAIN_HANDLER;
} else if (handler instanceof org.jboss.resteasy.reactive.server.handlers.NonBlockingHandler) {
handler.handle(this);
return NON_BLOCKING_HANDLER;
} else if (handler instanceof org.jboss.resteasy.reactive.server.handlers.BlockingHandler) {
handler.handle(this);
return BLOCKING_HANDLER;
} else if (handler instanceof org.jboss.resteasy.reactive.server.handlers.ResourceRequestFilterHandler) {
handler.handle(this);
return RESOURCE_REQUEST_FILTER_HANDLER;
} else if (handler instanceof org.jboss.resteasy.reactive.server.handlers.InputHandler) {
handler.handle(this);
return INPUT_HANDLER;
} else if (handler instanceof org.jboss.resteasy.reactive.server.handlers.RequestDeserializeHandler) {
handler.handle(this);
return REQUEST_DESERIALIZE_HANDLER;
} else if (handler instanceof org.jboss.resteasy.reactive.server.handlers.ParameterHandler) {
handler.handle(this);
return PARAMETER_HANDLER;
} else if (handler instanceof org.jboss.resteasy.reactive.server.handlers.InstanceHandler) {
handler.handle(this);
return INSTANCE_HANDLER;
} else if (handler instanceof org.jboss.resteasy.reactive.server.handlers.InvocationHandler) {
handler.handle(this);
return INVOCATION_HANDLER;
} else if (handler instanceof org.jboss.resteasy.reactive.server.handlers.FixedProducesHandler) {
handler.handle(this);
return FIXED_PRODUCES_HANDLER;
} else if (handler instanceof org.jboss.resteasy.reactive.server.handlers.ResponseHandler) {
handler.handle(this);
return RESPONSE_HANDLER;
} else if (handler instanceof org.jboss.resteasy.reactive.server.handlers.ResponseWriterHandler) {
handler.handle(this);
return RESPONSE_WRITER_HANDLER;
} else {
// megamorphic call for other handlers
handler.handle(this);
return -1;
}
}
}
8 changes: 6 additions & 2 deletions ...rc/main/java/org/jboss/resteasy/reactive/common/core/AbstractResteasyReactiveContext.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public abstract class AbstractResteasyReactiveContext<T extends AbstractResteasy
private boolean closed = false;

public AbstractResteasyReactiveContext(H[] handlerChain, H[] abortHandlerChain, ThreadSetupAction requestContext) {
this.handlers = handlerChain;
setHandlers(handlerChain);
this.abortHandlerChain = abortHandlerChain;
this.requestContext = requestContext;
}
Expand Down Expand Up @@ -280,8 +280,12 @@ public void restart(H[] newHandlerChain) {
restart(newHandlerChain, false);
}

public void restart(H[] newHandlerChain, boolean keepTarget) {
protected void setHandlers(H[] newHandlerChain) {
this.handlers = newHandlerChain;
}

public void restart(H[] newHandlerChain, boolean keepTarget) {
setHandlers(newHandlerChain);
position = 0;
restarted(keepTarget);
}
Expand Down
2 changes: 1 addition & 1 deletion ...src/main/java/org/jboss/resteasy/reactive/server/core/ResteasyReactiveRequestContext.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ public void restart(RuntimeResource target) {
}

public void restart(RuntimeResource target, boolean setLocatorTarget) {
this.handlers = target.getHandlerChain();
setHandlers(target.getHandlerChain());
position = 0;
parameters = target.getParameterTypes().length == 0 ? EMPTY_ARRAY : new Object[target.getParameterTypes().length];
if (setLocatorTarget) {
Expand Down

0 comments on commit 72d7483

Please sign in to comment.