Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on Cljs 1.10.238 #7

Merged
merged 3 commits into from
Mar 27, 2018
Merged

Fix on Cljs 1.10.238 #7

merged 3 commits into from
Mar 27, 2018

Conversation

Deraen
Copy link
Contributor

@Deraen Deraen commented Mar 27, 2018

Fixes #6

@frankiesardo
Copy link
Owner

Thank you 🎩

@frankiesardo frankiesardo merged commit e13c742 into frankiesardo:master Mar 27, 2018
@Deraen
Copy link
Contributor Author

Deraen commented Mar 27, 2018

@frankiesardo I'd recommend rewriting circle.yml to use Circle v2, like this:

version: 2
jobs:
  build:
    working_directory: ~/work
    docker:
      - image: circleci/clojure:boot-2.7.2
    steps:
      - checkout
      - restore_cache:
          keys:
            - v1-{{ checksum "boot.properties" }}-{{ checksum "build.boot" }}
            - v1-
      - run: boot test
      - save_cache:
          paths:
            - ~/.m2
            - ~/.boot/cache/lib
            - ~/.boot/cache/bin
          key: v1-{{ checksum "boot.properties" }}-{{ checksum "build.boot" }}

Not sure what to do with deployment part. Maybe second job using same Boot image and running boot deploy. And then adding workflow to run deploy job if branch is master etc: https://circleci.com/docs/2.0/deployment-integrations/

@Deraen
Copy link
Contributor Author

Deraen commented Mar 27, 2018

@frankiesardo
Copy link
Owner

Thanks but I think in the next future I'd like to move the project to deps.edn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants