-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improvements to make more composable #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
francisashley
commented
Jan 1, 2025
•
edited
Loading
edited
- feat: Removed spreadsheet view. Direct cell modifications are currently out of scope. For row editing support, consider creating a custom modal with a form for remote editing.
- feat: Added VueScreener suffix to all components to clearly indicate package origin.
- ref: Renamed terminology from "item" to "row". VueScreener now consistently uses "rows", "columns" and "cells".
- feat: Made vue-screener state prop optional. Component defaults to internal state, with option for remote control override.
- ui: Replaced icons with codicon to simplify codebase and improve ui.
- feat: Implemented tailwind-merge for class handling. Override tailwind classes without needing ! prefix.
- feat: Enhanced composability support. Rather than configuring via a large UI prop, VueScreener now offers two approaches: a base component with minimal control, or individual customizable components. This promotes more declarative styling by reducing the gap between components and their styles.
- ref: Simplified prop naming conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.