Remove Custom RPC methods and Use Runtime API methods Instead (Blocked by Polkadot.js bug) #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substrate has stopped using custom RPC methods for most of its pallets and instead they allow runtime APIs to be called directly using the RPC
state_call(https://polkadot.js.org/docs/substrate/rpc/#callmethod-text-data-bytes-at-blockhash-bytes).Here's an example of Substrate removing the custom RPC methods for
pallet-dex: paritytech/substrate#13050Therefore, in this PR I have removed the custom RPC methods. However, this PR cannot be merged since the output of the runtime API methods is being incorrectly decoded by polkadot.js. (Hence the tests in
rpc/test/rpc-tests.jsfail). This is a known problem with polkadot.js since October 2022: polkadot-js/api#5298Therefore, this PR is blocked until polkadot.js fixes polkadot-js/api#5298