-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve the debug logging #627
Merged
Merged
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
=====================================
Coverage 90.3% 90.4%
=====================================
Files 33 33
Lines 964 970 +6
Branches 188 189 +1
=====================================
+ Hits 871 877 +6
Misses 79 79
Partials 14 14 ☔ View full report in Codecov by Sentry. |
mkniewallner
approved these changes
Mar 23, 2024
Loading status checks…
…logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docs
is updatedDescription of changes
Improved debug logging: All imported modules and their locations were printed to a single line; this is now printed as indented
json
so it's easier for users to debug. For an example, see below.In addition, the modules are now sorted after collecting them from Rust, so they now are sorted in alphabetical order in other locations in the logs too. This makes it easier to find information regarding a module in the logging output.
before
after