Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid use of sys.version to obtain Python version #24

Merged
merged 1 commit into from
Sep 11, 2017

Conversation

svisser
Copy link
Contributor

@svisser svisser commented Sep 10, 2017

This change converts use of sys.version to sys.version_info as sys.version is not guaranteed to contain the version number at the beginning of the string across Python implementations (see also the note at https://docs.python.org/2/library/sys.html#sys.version).

@foutaise foutaise merged commit 06bc2b4 into foutaise:master Sep 11, 2017
@foutaise
Copy link
Owner

Hi @svisser,

Good catch! Thanks for your PR.

Regards,

@svisser
Copy link
Contributor Author

svisser commented Sep 11, 2017

Thanks for merging it in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants