feat(forge): remove testFail*
#9574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
reviewed
Dec 19, 2024
forge): deprecate testFail*forge): remove testFail*
Moved to ExpectRevertFailures.t.sol in cli tests
60e0887 to
1eda9a5
Compare
forge): remove testFail*forge): remove testFail*
This reverts commit a9e7568.
grandizzy
approved these changes
Jan 29, 2025
| ExtTester::new("transmissions11", "solmate", "c892309933b25c03d32b1b0d674df7ae292ba925"); | ||
| // <https://github.com/transmissions11/solmate> | ||
| // #[test] | ||
| // fn solmate() { |
There was a problem hiding this comment.
is this going to be replaced with something else or should we remove it?
| .args(["--chain-id", "99", "--sender", "0x00a329c0648769A73afAc7F9381E08FB43dBEA72"]) | ||
| fn snekmate() { | ||
| ExtTester::new("pcaversaccio", "snekmate", "df226f4a45e86c8f8c3ff1f9fa3443d260002050") | ||
| .args(["--nmc", "ERC4626VaultTest"]) |
There was a problem hiding this comment.
makes sense, this is not in snekmate master anymore, we'll update once a stable 0.4.1 vyper version to pin in CI
zerosnacks
reviewed
Jan 29, 2025
| #[test] | ||
| fn forge_std() { | ||
| ExtTester::new("foundry-rs", "forge-std", "2b59872eee0b8088ddcade39fe8c041e17bb79c0") | ||
| ExtTester::new("foundry-rs", "forge-std", "08d6af5d6c8a9a60e308b689cd19751876d321e0") |
There was a problem hiding this comment.
Just for future reference, this commit is from this PR: foundry-rs/forge-std#643
There was a problem hiding this comment.
yeah, maybe we could have additional reviewers for that forge-std PR, bump @mds1 :)
zerosnacks
added a commit
to foundry-rs/forge-std
that referenced
this pull request
Jan 31, 2025
In preparation to deprecate `testFail*`: foundry-rs/foundry#9574 - Removes `deployMockERC721` and `deployMockERC20` from `StdUtils` as their tests includes large amount of `testFail*` tests and is generally outdated. I haven't been able to find the `deploy*` methods being used in any public project on Github. - Implements workaround for other cases Alternatively we could upstream Solady's mocks and tests (which have been updated to not use `testFail*` but this feels out of place and would be incomplete (ERC4626, ERC6909, etc.. https://github.com/Vectorized/solady/tree/main/test/utils/mocks). I think it is most common for people to rely on the mocks their library comes with (be it Solmate, Solady or OpenZeppelin) or write their own wrapper around the token implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4437
Solution
testFail*.testFail*, to cli tests in order to assert internal tooling failure. See failure_assertions.rs