Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cheatcodes): overflow in randomNumber w/range #8361

Merged
merged 1 commit into from
Jul 4, 2024
Merged

fix(cheatcodes): overflow in randomNumber w/range #8361

merged 1 commit into from
Jul 4, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Jul 4, 2024 •
edited
Loading

randomUint(0, -1) panics with division by zero due to overflow in rand() % (-1 - 0 + 1)

@DaniPopes DaniPopes force-pushed the dani/randomnumber-overflow branch from 1767d00 to bab843b Compare July 4, 2024 17:21
@DaniPopes DaniPopes force-pushed the dani/randomnumber-overflow branch from bab843b to 7996e11 Compare July 4, 2024 17:25
@DaniPopes DaniPopes enabled auto-merge (squash) July 4, 2024 17:29
@DaniPopes DaniPopes merged commit 56dbd20 into master Jul 4, 2024
20 checks passed
@DaniPopes DaniPopes deleted the dani/randomnumber-overflow branch July 4, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @klkvr