Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize debug node flatten_to method #7398

Closed
wants to merge 2 commits into from
Closed

optimize debug node flatten_to method #7398

wants to merge 2 commits into from

Conversation

MuhtasimTanmoy
Copy link

Context: #7386

@DaniPopes
Copy link
Member

I don't think this helps, the problem is the cloning in flat rather than the recursion itself,

@MuhtasimTanmoy
Copy link
Author

MuhtasimTanmoy commented Mar 13, 2024 •
edited
Loading

Ok. Looking into it.

I picked up this line from issue.

since we're consuming the type, we can get rid of the clones by rewriting this with a stack approach

@onbjerg
Copy link
Collaborator

onbjerg commented Mar 19, 2024

What's the status on this? @MuhtasimTanmoy

@DaniPopes
Copy link
Member

This is not the right approach, and I've found another place to improve performance in #7468. Thanks for the PR anyway!

@DaniPopes DaniPopes closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MuhtasimTanmoy @DaniPopes @onbjerg