feat(forge): add calldata and returndata views to debugger #7110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r scroll down calculations
DaniPopes
requested changes
Feb 14, 2024
DaniPopes
reviewed
Feb 14, 2024
crates/debugger/src/tui/draw.rs
Outdated
| opcode::CREATE | opcode::CREATE2 => (2, 3, 0, 0), | ||
| opcode::CALL | opcode::CALLCODE => (4, 5, 0, 0), | ||
| opcode::DELEGATECALL | opcode::STATICCALL => (3, 4, 0, 0), | ||
| ) -> (Option<BufferKind>, Option<usize>, Option<usize>, Option<usize>, Option<usize>) { |
There was a problem hiding this comment.
Clippy is complaining about this, which is fair. You can extract it into a struct and return one Option<_>
Evalir
approved these changes
Feb 14, 2024
DaniPopes
approved these changes
Feb 14, 2024
emo-eth
added a commit
to emo-eth/foundry
that referenced
this pull request
Feb 14, 2024
…oundry-rs#7110)" This reverts commit e10b039.
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's often useful to see what data is actually in calldata/returndata, as well as see which regions are being operated on.
Closes #5492.
Solution
DebugStepactive_buffertoDebuggerContextget_memory_access->get_buffer_accesses; note which buffer is being read from, if any; simplify return typedraw_memory->draw_buffer; compare read/writes to current active bufferb("buffer") operator to debugger to cycle Memory -> Calldata -> Returndata buffers in the "buffer" panel viewbto help string; update references of "memory" to "buffer"Unsure of where debugger tests live (if anywhere), but draw logic seems to handle edge cases well; I'd be most concerned about potential performance issues or highlighting regions in the wrong buffer.
Screenshots:
Calldata access:
Memory overwrite from calldatacopy:
Returndata access:
Memory overwrite from returndatacopy: