-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parsing file paths from foundry.toml #7063
Merged
mattsse
merged 6 commits into
foundry-rs:master
from
loocapro:ignore/dependencies/warnings
Feb 9, 2024
Merged
parsing file paths from foundry.toml #7063
mattsse
merged 6 commits into
foundry-rs:master
from
loocapro:ignore/dependencies/warnings
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you pls rebase to run CI #7064 |
mattsse
requested changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only naming nits
249cb27
to
d43f28e
Compare
mattsse
requested changes
Feb 9, 2024
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
mattsse
approved these changes
Feb 9, 2024
This was referenced Apr 26, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Related to: #1200
Solution
Adding
ignored_file_paths
field and parsing it.