fix(cast/call): remove --verbose, fix --debug #6939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffceb99 to
93f3042
Compare
93f3042 to
23ac1fc
Compare
mattsse
approved these changes
Jan 29, 2024
tomholford
added a commit
to tomholford/book
that referenced
this pull request
Jan 31, 2024
This updates the docs to reflect that the `--verbose` flag was removed from `call`. See: foundry-rs/foundry#6939 foundry-rs/foundry#6219
mattsse
pushed a commit
to foundry-rs/book
that referenced
this pull request
Jan 31, 2024
This updates the docs to reflect that the `--verbose` flag was removed from `call`. See: foundry-rs/foundry#6939 foundry-rs/foundry#6219 Co-authored-by: tomholford <tomholford@users.noreply.github.com>
This was referenced Apr 26, 2024
togetherAll7
pushed a commit
to togetherAll7/foundry-book
that referenced
this pull request
Nov 17, 2024
This updates the docs to reflect that the `--verbose` flag was removed from `call`. See: foundry-rs/foundry#6939 foundry-rs/foundry#6219 Co-authored-by: tomholford <tomholford@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
cast call --trace --verbosefunctionality was removed in #6219 (it didn't do anything), but it wasn't removed as a flag and it was incorrectly passed instead of--debug's value when callinghandle_traces.Drive-by: fix double terminal clear in case of debugger panics, and fix a debugger panic by hoisting a check to before creating the internal context.
Closes #6938
Solution