Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle nulls in 4byte response #6867

Closed
wants to merge 1 commit into from
Closed

fix: handle nulls in 4byte response #6867

wants to merge 1 commit into from

Conversation

DaniPopes
Copy link
Member

Motivation

Values in the function and event maps may be null: SignatureResponse in https://docs.openchain.xyz/#/

Solution

Handle null responses by making the selector maps' values optional.

@cdump
Copy link
Contributor

cdump commented Jan 20, 2024 •
edited
Loading

@DaniPopes it's already fixed in master - https://github.com/foundry-rs/foundry/blob/master/crates/common/src/selectors.rs#L188 by #6863

@DaniPopes DaniPopes closed this Jan 20, 2024
@DaniPopes DaniPopes deleted the dani/fix-4byte branch January 20, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniPopes @cdump @mattsse