Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update env in transact cheatcode #6835

Merged

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jan 17, 2024

closes #6538

see docs for more context.

TLDR: we need to update the env.block to the transaction's block so we can transact it in the block env it was mined in

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@mattsse mattsse force-pushed the matt/fix-transact-cheatcode-issue branch from 43d3bf9 to 701a839 Compare January 17, 2024 22:10
@mattsse mattsse merged commit 648a535 into foundry-rs:master Jan 17, 2024
19 checks passed
@foundry-rs foundry-rs deleted a comment from Jaxs88 Jan 20, 2024
@foundry-rs foundry-rs deleted a comment from Jaxs88 Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encountered GasPriceLessThanBasefee error when executing vm.transact
2 participants