fix(cheatcodes): Include calls to create2 factory in state diff recording #6650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b58944 to
24f85c0
Compare
24f85c0 to
1924857
Compare
1924857 to
8c81779
Compare
mds1
reviewed
Dec 22, 2023
Comment on lines
+1241
to
+1243
| // If the create scheme is Create2 and the depth equals the broadcast/prank/default | ||
| // depth, then record an additional call to the create2 factory. | ||
| if data.journaled_state.depth() == base_depth { |
There was a problem hiding this comment.
I believe this PR would result in a correct state diff for scripts, but not tests, because of #5529
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #6634 by including the call to the create2 factory in the state diff results. Note that this PR does not resolve a related issue where the call to the create2 factory is not included in traces. As far as I can tell, these issues resemble each other but are not directly related. So, I think it makes sense to solve them separately.
Solution
Resolved by adding logic to record an additional call to the create2 factory if the call scheme is
CreateScheme::Create2and the call depth is equal to the prank/broadcast depth.