Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: precompile trace decoding #6263

Merged
merged 9 commits into from
Nov 9, 2023
Merged

fix: precompile trace decoding #6263

merged 9 commits into from
Nov 9, 2023

Conversation

DaniPopes
Copy link
Member

Fixes #6262

Two bugs here:

  • shouldn't assume that raw calldata is at least 4 bytes
  • return is wrong because we're in a loop

@DaniPopes DaniPopes marked this pull request as ready for review November 9, 2023 09:29
@DaniPopes DaniPopes marked this pull request as draft November 9, 2023 11:18
@DaniPopes DaniPopes marked this pull request as ready for review November 9, 2023 11:34
Evalir
Evalir approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure seems unrelated

@DaniPopes DaniPopes merged commit 9194d86 into master Nov 9, 2023
@DaniPopes DaniPopes deleted the dani/fix-precompile-decoding branch November 9, 2023 12:12
@pcaversaccio pcaversaccio mentioned this pull request Nov 10, 2023
Closed
2 tasks
@dantaik dantaik mentioned this pull request Nov 12, 2023
Merged
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Evalir Evalir Evalir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: The application panicked (crashed). assertion failed: mid <= self.len()
3 participants
@DaniPopes @mattsse @Evalir