feat(forge): commit state between invariant runs

[Evalir]

Motivation

Closes #3005.

Solution

Do not drop the executor between runs, but rather use the same executor.

[mattsse]

looks reasonable

[Evalir]

This is incredibly slow though @mattsse — do you think there's another way to do this? If not, we probably shouldn't do this because of performance regressions.

[Evalir]

Hey @mds1 looping you in here too—This is a direct fix for #3005 but introduces serious performance regressions, and i'm unsure if we have another way of doing this. I'd say we should hold off of merging this

[mds1]

Hmm, can you help me understand why this has such a big performance regression? We already commit state for all non-test contracts, so it seems surprising that committing state for the test contract would cause this

[Evalir]

Yep, so, it's because we persist the peripheral contract's state in a different way altogether—it's much cheaper since we're not really "growing" the internal executor changeset, but rather collecting the run state and then using this to find the next inputs.

For committing the invariant state we'd need to keep the used executor alive, and this means that for each depth of each run, the in-memory db will grow, and it'll get slower and slower as a result

[Evalir]

@mds1 @mattsse nevermind about performance regressions—something was affecting my environment and made builds super slow. Just moved to my new laptop and this is fine.

Just tested doing foundryup from this branch commit and the performance difference seems completely negligible. I think we can merge this in if this is truly the case! Just a sanity test, can you test this branch @mds1 ?

[mds1]

nevermind about performance regressions—something was affecting my environment and made builds super slow. Just moved to my new laptop and this is fine.

Oh awesome, that's great news!

Definitely can test, cc @lucas-manuel @PaulRBerg to sanity test also :)

[Evalir]

Closing, this is not the correct solution to #3005 — i'll followup with the proper fix