Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate revm 3.0 #4472

Closed
wants to merge 1 commit into from
Closed

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Mar 3, 2023

Motivation

bump revm to 3.0

this is a bit horrible...

@DaniPopes would you be interested in taking on this task by any chance?
I know it's pretty thankless work, but it's desperately needed.

There are a lot of breaking changes due to revm and the ruint/primtive-types situation.

I think the right approach would be to migrate foundry-evm first, step by step

Solution

@mattsse mattsse changed the title start fix breaking changes chore: migrate revm 3.0 Mar 3, 2023
@Evalir
Copy link
Member

Evalir commented Mar 15, 2023

Hey @mattsse , i think with some guidance I should be able to at least soften the workload on this—Happy to help on it!

@mattsse
Copy link
Member Author

mattsse commented Mar 15, 2023

this would be much appreciated.

we have a lot of breaking changes here.

mainly affecting the foundry-evm crate, which we should focus on first.

Tbh I guess the best approach is by letting the compiler guide you. I started with replacing revm types, there's still some work to do with all the new types, for example everything that calls evm.transact etc needs to be updated.

I'd probably start with running cargo c in foundry-evm and start fixing errors.

@Evalir
Copy link
Member

Evalir commented Mar 15, 2023

awesome, will do—i'll start by branching off from here then (unless you want it done another way)

@mattsse
Copy link
Member Author

mattsse commented Mar 15, 2023

sg!
also recommend bumping revm again, we have additional From impls for the different H256 U256 types now

@Evalir
Copy link
Member

Evalir commented Mar 16, 2023

just started here: mattsse#2

as you're working from a fork i had to direct the PR to your repo instead of upstream

as for revm, you're talking about bluealloy/revm#398 right? if so i think we need to do another revm release

will be leaving more questions on the pr!

@mattsse mattsse mentioned this pull request Apr 9, 2023
2 tasks
@mattsse mattsse mentioned this pull request Apr 17, 2023
@mattsse mattsse closed this Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants