-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add foundry-binder crate #1257
Conversation
Should we not use this in |
slightly different use case, forge bind is intended to generate bindings for the current foundry project. whereas this is intended to generate them for any repo in one step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - worth maybe adding a change to https://github.com/gakonst/foundry-rust-template so that we show how integration with third party contracts + forge bind works
I'm not sure I understand - this crate seems to be able to use a local path as opposed to a remote repository as well? 🤔 Is there any reason we could not merge them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm this seems pretty simple - I just thought we were duplicating some stuff where we could avoid it
lgtm
Motivation
Provide a one step solution to generate ethers-rs bindings for any solidity project.
Example usage https://github.com/mattsse/defi-bindings
Solution
The configurable
Binder
type willTo improve