Fix formatter #74
Merged
Fix formatter #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97176b8 to
e5a86a8
Compare
fabianlim
reviewed
Aug 23, 2024
scripts/benchmarks/benchmark.py
Outdated
| @@ -430,8 +428,8 @@ def is_completed(self): | |||
| # return complete only if no errors | |||
| # and is not a dry run | |||
There was a problem hiding this comment.
lets not format anything in scripts/benchmarks since there is another PR #69 making changes to these files.
e5a86a8 to
61f5c72
Compare
Signed-off-by: 1000850000 user <aaron.chew1@ibm.com>
Signed-off-by: 1000850000 user <aaron.chew1@ibm.com>
61f5c72 to
bbd08be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR formats the code and fixes the format workflow to fail if additional formatting is required in GH Actions