Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Copy KHD imports into scattermoe_utils #127

Merged
merged 10 commits into from
Mar 5, 2025

Conversation

willmj
Copy link
Collaborator

@willmj willmj commented Feb 21, 2025

Scatter MoE has been using kernel hyperdrive as an external dependency since it's not a pypi library, which makes installation more difficult. Therefore we copy the functions we depend on into scattermoe_utils.khd to remove this dependency.

Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
@willmj willmj requested a review from fabianlim as a code owner February 21, 2025 21:10
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
@@ -0,0 +1,349 @@
# Third Party
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haev a line here that references cute kernels would be good.

@@ -0,0 +1,310 @@
# Copyright The FMS HF Tuning Authors
# Copyright 2024 Databricks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is not from databricks, it is from cute kernels

import triton.language as tl

BLOCK_M = 128

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here this is from cute kernels

@fabianlim fabianlim self-requested a review February 21, 2025 23:29
Copy link
Contributor

@fabianlim fabianlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some minor changes

willmj added 3 commits March 4, 2025 11:22
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
@fabianlim fabianlim merged commit de9a4f1 into foundation-model-stack:main Mar 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants