Apply suggestions from code review

Co-authored-by: Yu Chin Fabian Lim <fabianlim@users.noreply.github.com>
foundation-model-stack · Aug 19, 2024 · 02a11f9 · 02a11f9
1 parent 97529d2
commit 02a11f9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/scripts/benchmarks/benchmark.py b/scripts/benchmarks/benchmark.py
@@ -198,7 +198,9 @@ def prepare_dataset(
             if response_template is not None:
                 warnings.warn(
                     "Response Template detected in data processing field, "
-                    "overriding response template."
+                    "overriding response template. "
+                    "*** Old ***\n{response_template}\n"
+                    "*** New ***\n{self.response_template}"
                 )
             response_template = self.response_template
 

diff --git a/scripts/run_benchmarks.sh b/scripts/run_benchmarks.sh
@@ -45,7 +45,6 @@ NUM_GPUS_MATRIX=${1-"1 2"}
 RESULT_DIR=${2:-"benchmark_outputs"}
 SCENARIOS_CONFIG=${3:-$SCENARIOS_CONFIG}
 SCENARIOS_FILTER=${4-$SCNTAG_PEFT_AUTOGPTQ}
-DEFAULTS_CONFIG=${5:-$DEFAULTS_CONFIG}
 
 echo "NUM_GPUS_MATRIX: $NUM_GPUS_MATRIX"
 echo "RESULT_DIR: $RESULT_DIR"