Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(julia): Add julia language support #56

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Conversation

aman1971
Copy link
Contributor

pull request for #34

@GMishx
Copy link
Member

GMishx commented Jan 12, 2022

Hello @aman1971 . Thank you for your contribution but we have recently merged a PR for Julia #52

Since your changes are also interesting and compliment changes in #52, can you please rebase your changes on top of it and push?

@aman1971
Copy link
Contributor Author

Okay sir

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Need test.

@GMishx
Copy link
Member

GMishx commented Jan 27, 2022

@aman1971 can you please squash your commits into one so we can go head with merging your branch?

@GMishx
Copy link
Member

GMishx commented Jan 28, 2022

Looks like linter is failing @aman1971

./nirjas/binder.py:326:61: W292 no newline at end of file
./nirjas/languages/tests/test_julia.py:153:1: W293 blank line contains whitespace
Error: Process completed with exit code 1.

Please fix the issue and amend in the same commit.

@aman1971
Copy link
Contributor Author

okay @GMishx

@GMishx GMishx merged commit 0e763df into fossology:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants