Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(code-quality): Improve code quality reported by pylint #33

Merged
merged 6 commits into from
Oct 6, 2021

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Apr 28, 2021

Improve code quality by fixing errors reported by pylint.

Changes include:

  • Remove unused variables.
  • Ignore unused return values.
  • Limit line length to 100 characters.
  • Add a new line at file end.
  • Adding doc strings to modules, files, classes and functions.

Depends on #32

GMishx added 5 commits April 28, 2021 21:03
Add negative lookbehind to single line comment regex to make sure the
comment symbol is not part of a string ('#' is a string, not a comment).

Add new function `hashNoCurl()` for Ruby's #{} string syntax.

Also, updated `readMultiLineSame()` to check if the comment starts and
ends in the same line and do not pick a line with comment symbol in
string.

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
@GMishx GMishx force-pushed the chore/code-quality/improvement branch from 3d0e6ed to 1806583 Compare April 28, 2021 15:44
@Kaushl2208 Kaushl2208 self-requested a review October 6, 2021 05:30
testScript.py Outdated Show resolved Hide resolved
Copy link
Member

@Kaushl2208 Kaushl2208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 69 tests in 0.262s

FAILED (errors=6)

Few Test cases are failing,!!

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
@GMishx GMishx force-pushed the chore/code-quality/improvement branch from 1806583 to 444833e Compare October 6, 2021 06:05
@GMishx
Copy link
Member Author

GMishx commented Oct 6, 2021

Ran 69 tests in 0.262s

FAILED (errors=6)

Few Test cases are failing,!!

That I believe is encoding issues with Windows. The test files and repository is intended for Linux.

You can see the test cases running in GitHub Actions.

@Kaushl2208
Copy link
Member

Gotcha, Thanks!

@Kaushl2208 Kaushl2208 merged commit 53d64b7 into master Oct 6, 2021
@GMishx GMishx deleted the chore/code-quality/improvement branch October 6, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants