-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(code-quality): Improve code quality reported by pylint #33
Conversation
Add negative lookbehind to single line comment regex to make sure the comment symbol is not part of a string ('#' is a string, not a comment). Add new function `hashNoCurl()` for Ruby's #{} string syntax. Also, updated `readMultiLineSame()` to check if the comment starts and ends in the same line and do not pick a line with comment symbol in string. Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
3d0e6ed
to
1806583
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran 69 tests in 0.262s
FAILED (errors=6)
Few Test cases are failing,!!
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
1806583
to
444833e
Compare
That I believe is encoding issues with Windows. The test files and repository is intended for Linux. You can see the test cases running in GitHub Actions. |
Gotcha, Thanks! |
Improve code quality by fixing errors reported by
pylint
.Changes include:
Depends on #32