Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(setup): Added additional metainfo #11

Merged
merged 1 commit into from
Jul 29, 2020
Merged

chore(setup): Added additional metainfo #11

merged 1 commit into from
Jul 29, 2020

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Jul 29, 2020

  1. Added metainfo like license and platform to setup.py.
  2. Added MANIFEST.in to remove test data from package.
  3. New exception NotSupportedExtension to handle files with unknown extensions.
  4. Remove cwd infront of filename. (this was causing nirjas to not run on other directories).

Signed-off-by: Gaurav Mishra mishra.gaurav@siemens.com

@GMishx GMishx added the enhancement New feature or request label Jul 29, 2020
@GMishx GMishx requested review from hastagAB and Kaushl2208 July 29, 2020 11:17
Kaushl2208
Kaushl2208 approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@Kaushl2208 Kaushl2208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, Changes are working fine. 👍

hastagAB
hastagAB approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@hastagAB hastagAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be really beneficial if we could add Travis to Nirjas.

setup.py Outdated Show resolved Hide resolved
@GMishx
Copy link
Member Author

GMishx commented Jul 29, 2020

It would be really beneficial if we could add Travis to Nirjas.

I am working on that right now. Maybe you can create an issue and assign it to me.

@hastagAB
Copy link
Member

It would be really beneficial if we could add Travis to Nirjas.

I am working on that right now. Maybe you can create an issue and assign it to me.

Sure, Thanks!
I'm creating an issue.

@GMishx GMishx force-pushed the chore/setup/metainfo branch from 064fc58 to cd1a8e9 Compare July 29, 2020 13:54
@GMishx
chore(setup): Added additional metainfo
a260cae 
1. Added metainfo like license and platform to setup.py.
2. Added MANIFEST.in to remove test data from package.
3. New exception NotSupportedExtension to handle files with unknown
   extensions.
4. Remove `cwd` infront of filename.

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
@GMishx GMishx force-pushed the chore/setup/metainfo branch from cd1a8e9 to a260cae Compare July 29, 2020 13:54
@hastagAB hastagAB merged commit c6a1a99 into master Jul 29, 2020
@GMishx GMishx deleted the chore/setup/metainfo branch July 29, 2020 14:06
@hastagAB hastagAB mentioned this pull request Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hastagAB hastagAB hastagAB approved these changes

@Kaushl2208 Kaushl2208 Kaushl2208 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GMishx @hastagAB @Kaushl2208