Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the logic to exclude files #81

Closed
wants to merge 7 commits into from
Closed

Change the logic to exclude files #81

wants to merge 7 commits into from

Conversation

soimkim
Copy link
Contributor

@soimkim soimkim commented Jul 15, 2022

Description

  • Changed logic to find and remove files excluded from yaml
    • AS-IS: Find list of files to exclude from yaml in files without license/copyright and remove them later.
    • TO-BE: If you find a file to be excluded from yaml in a file without license/copyright, remove it immediately.
  • OSS Package file is excluded from the list of files without license/copyright
  • The name of the yaml file to parse:
    • AS-IS: oss-pkg-info.yaml
    • TO-BE: oss-pkg-info*.yaml
  • How to match against files written to yaml:
    • AS-IS: File name pattern match using fnmath
    • TO-BE: Match the file name pattern using fnmath, and if it does not match, match regular expression
      Reason: When only the folder name is written (ex. In case of temp, to match all temp/*)
  • Fixed bug where oss-pkg-info*.yaml file could not be found in OSS Package file list

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Jul 15, 2022
@soimkim soimkim requested a review from bjk7119 July 15, 2022 06:26
@soimkim soimkim marked this pull request as draft July 15, 2022 06:26
@bjk7119 bjk7119 force-pushed the develop branch 2 times, most recently from b7bed6a to c0b0e09 Compare July 15, 2022 07:09
@soimkim soimkim marked this pull request as ready for review July 15, 2022 07:50
@soimkim soimkim self-assigned this Jul 15, 2022
@soimkim
Copy link
Contributor Author

soimkim commented Jul 15, 2022

Replace with #83

@soimkim soimkim closed this Jul 15, 2022
@bjk7119 bjk7119 deleted the temp_fnmatch branch July 18, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [PR/Issue] Refactoring, maintenance the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants