Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to error about escape character #155

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix to error about escape character #155

merged 1 commit into from
May 21, 2024

Conversation

bjk7119
Copy link
Contributor

@bjk7119 bjk7119 commented May 16, 2024 •
edited
Loading

Description

  • Replace windows path separator to linux's('\\' -> '/') regardless of OS
  • Log the pattern when find unmatched pattern

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@bjk7119 bjk7119 added the bug fix [PR] Fix the bug label May 16, 2024
@bjk7119 bjk7119 requested review from soimkim and dd-jy May 16, 2024 04:55
@bjk7119 bjk7119 self-assigned this May 16, 2024
@bjk7119 bjk7119 force-pushed the develop branch 4 times, most recently from c26fcc1 to 6ab8a09 Compare May 20, 2024 09:43
soimkim
soimkim requested changes May 21, 2024
View reviewed changes
@bjk7119 bjk7119 requested a review from soimkim May 21, 2024 02:19
@bjk7119 bjk7119 merged commit 9820c32 into main May 21, 2024
5 checks passed
@dd-jy dd-jy deleted the develop branch September 9, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soimkim soimkim soimkim approved these changes

@dd-jy dd-jy dd-jy approved these changes

Assignees

@bjk7119 bjk7119

Labels
bug fix [PR] Fix the bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjk7119 @soimkim @dd-jy