fix #66 random text response #67
Conversation
| try: | ||
| identity_json = parsed_dict['session']['identity'] | ||
| identity = Identity(identity_json) | ||
| session = Session(identity) | ||
| except KeyError: | ||
| session = None | ||
|
|
||
| return QueryResponse(answer,parsed_dict, session) | ||
| if parsed_dict['answers']: |
There was a problem hiding this comment.
Check if the len of parse_dict[answers] is not zero
and update accordingly
There was a problem hiding this comment.
This returns false if it's empty, it works either way. Should I change it?
|
Please mention the issue you are working on by linking to the issue number |
There was a problem hiding this comment.
@abhisharma404 , please create / refer the issue that you are solving prior to making a PR
|
@abhisharma404 Which issue are you solving? Where is the bug reported? |
|
The corresponding issue is this #66 @mariobehling |
|
I'm sorry I was a bit busy with my exams. The issue that I had worked on is #66. |
There was a problem hiding this comment.
@prateekiiest @abhisharma404 , I believe this change will cause errors in SUSI Linux . As we expect an empty response there.
|
I believe you are right @stealthanthrax |
|
Should this be closed then? |
|
Due to the current breaking, I think we cant incorporate this. |
|
rejected by developers |
The random text query bug is fixed, this is the result :