[RTE-241] Always fetch early variant of DCAP artifacts #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzohreva
reviewed
Jan 21, 2025
| @@ -430,7 +430,7 @@ impl<'inp> ProvisioningServiceApi<'inp> for QeIdApi { | |||
| fn build_request(&self, input: &Self::Input) -> Result<(String, Vec<(String, String)>), Error> { | |||
| let api_version = input.api_version as u8; | |||
| let url = format!( | |||
| "{}/sgx/certification/v{}/qe/identity", | |||
| "{}/sgx/certification/v{}/qe/identity?update=early", | |||
There was a problem hiding this comment.
I think these need to be added in PCCS as well?
There was a problem hiding this comment.
Good catch! I've updated the last commit.
There was a problem hiding this comment.
Does this apply to Azure as well?
There was a problem hiding this comment.
The Azure client fetches the TcbInfo and QeIdentity data from Intel and thus also pull in the changes in this PR.
da2aaa1 to
b0d6bb6
Compare
b0d6bb6 to
f4aec4b
Compare
mzohreva
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default we want to fetch the "early" variant of DCAP artifacts. See the pcs API documentation.