Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tab tray customizations #58

Closed
wants to merge 1 commit into from

Conversation

miDeb
Copy link

@miDeb miDeb commented Sep 3, 2020

Adds an option to bring back the fab and to select a direction to open the tab tray.
@abhijitvalluri could you review? :)
The default is still the same as before.
Maybe someone could suggest better strings for the settings? I don't think they're currently very good.
screenshots:
Screenshot_20200903-162839_Iceweasel Preview
Screenshot_20200903-164109_Iceweasel Preview

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@abhijitvalluri
Copy link
Collaborator

Dang it, I am working on the same set of features and some more actually! :D How do we go about resolving conflicts?

@miDeb
Copy link
Author

miDeb commented Sep 3, 2020

Hey, what a coincidence! If you are working on a bigger set of changes, it would probably make more sense to take yours i guess. But obviously feel free to take stuff from my pr if you haven't yet implemented them

@abhijitvalluri
Copy link
Collaborator

@miDeb I finally created my PR #65! It took a lot more time than I expected due to some frustrating issues getting all the functionality and behaviour just right for all the configuration options. Getting scrollToTab() in TabTrayView.kt to work correctly took a lot of effort and frustrating tweaking, for example! But it is here finally, and I incorporated all your customization options. I copied over your top FAB layout. Check it out!

@miDeb
Copy link
Author

miDeb commented Sep 4, 2020

Very cool!

@miDeb miDeb closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants