Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand README and app strings to Iceraven Browser #121

Merged
merged 2 commits into from
Sep 17, 2020

Conversation

interfect
Copy link
Collaborator

This changes the user-facing strings and the README to say we are Iceraven and not Iceweasel.

This is part of #111.

@interfect interfect merged commit ad68fdc into fork Sep 17, 2020
@interfect
Copy link
Collaborator Author

Merging this in gave us a test failure:

   TEST: GIVEN sharedprefs contains installed engines WHEN installedSearchEngineIdentifiers THEN defaultEngines + customEngines ids are returned
    [Robolectric] org.mozilla.fenix.components.searchengine.FenixSearchEngineProviderTest.GIVEN sharedprefs contains installed engines WHEN installedSearchEngineIdentifiers THEN defaultEngines + customEngines ids are returned: sdk=28; resources=LEGACY
    [Robolectric] NOTICE: legacy resources mode is deprecated; see http://robolectric.org/migrating/#migrating-to-40
    I/AssetManager: no overlays.list file found
    I/MonitoringInstr: Instrumentation started!
    I [glean/GleanCrashReporterService] No crashes to record, or file not found.
  FAILURE

...

 Caused by: java.lang.NullPointerException
	at org.mozilla.fenix.components.searchengine.FenixSearchEngineProvider$refreshAsync$1.invokeSuspend(FenixSearchEngineProvider.kt:186)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	... 5 more

@interfect
Copy link
Collaborator Author

interfect commented Sep 17, 2020

I don't see how this would have caused that. I'm re-running the job to see if it's an intermittent failure or what.

See https://github.com/fork-maintainers/iceraven-browser/runs/1126607386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant