Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach release binaries to every created release #89

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

thomaseizinger
Copy link
Contributor

Resolves #88.

Here is a test release: https://github.com/thomaseizinger/cargo-msrv/releases/tag/v0.7.3
Here is the workflow run that created it: https://github.com/thomaseizinger/cargo-msrv/actions/runs/1066616782

It is triggered on making a new release via Github.

Copy link
Owner

@foresterre foresterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm happy with it, thanks!

I have left one minor comment, for my understanding on whether the initialisation of arch is necessary or not.

.github/workflows/build-release-binaries.yaml Show resolved Hide resolved
@thomaseizinger
Copy link
Contributor Author

@foresterre
Copy link
Owner

Great thanks!

@foresterre
Copy link
Owner

bors r+

bors bot added a commit that referenced this pull request Jul 29, 2021
89: Attach release binaries to every created release r=foresterre a=thomaseizinger

Resolves #88.

Here is a test release: https://github.com/thomaseizinger/cargo-msrv/releases/tag/v0.7.3
Here is the workflow run that created it: https://github.com/thomaseizinger/cargo-msrv/actions/runs/1066616782

It is triggered on making a new release via Github.

Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
@bors
Copy link
Contributor

bors bot commented Jul 29, 2021

Build failed:

@thomaseizinger
Copy link
Contributor Author

Build failed:

* [clippy](https://github.com/foresterre/cargo-msrv/runs/3196964175)

Is this something I need to take care of @foresterre ?

@foresterre
Copy link
Owner

foresterre commented Jul 29, 2021

Build failed:

* [clippy](https://github.com/foresterre/cargo-msrv/runs/3196964175)

Is this something I need to take care of @foresterre ?

No, I will fix it in a few minutes =); it's newly released lints from Clippy

@foresterre
Copy link
Owner

bors retry

@bors bors bot merged commit 1c142bc into foresterre:main Jul 29, 2021
@foresterre
Copy link
Owner

Thanks! 😄

foresterre pushed a commit that referenced this pull request Aug 1, 2022
89: Attach release binaries to every created release r=foresterre a=thomaseizinger

Resolves #88.

Here is a test release: https://github.com/thomaseizinger/cargo-msrv/releases/tag/v0.7.3
Here is the workflow run that created it: https://github.com/thomaseizinger/cargo-msrv/actions/runs/1066616782

It is triggered on making a new release via Github.

Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attach binaries as part of releases
2 participants