-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attach release binaries to every created release #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I'm happy with it, thanks!
I have left one minor comment, for my understanding on whether the initialisation of arch
is necessary or not.
Action run for new version: https://github.com/thomaseizinger/cargo-msrv/actions/runs/1077897661 |
Great thanks! |
bors r+ |
89: Attach release binaries to every created release r=foresterre a=thomaseizinger Resolves #88. Here is a test release: https://github.com/thomaseizinger/cargo-msrv/releases/tag/v0.7.3 Here is the workflow run that created it: https://github.com/thomaseizinger/cargo-msrv/actions/runs/1066616782 It is triggered on making a new release via Github. Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Build failed: |
Is this something I need to take care of @foresterre ? |
No, I will fix it in a few minutes =); it's newly released lints from Clippy |
bors retry |
Thanks! 😄 |
89: Attach release binaries to every created release r=foresterre a=thomaseizinger Resolves #88. Here is a test release: https://github.com/thomaseizinger/cargo-msrv/releases/tag/v0.7.3 Here is the workflow run that created it: https://github.com/thomaseizinger/cargo-msrv/actions/runs/1066616782 It is triggered on making a new release via Github. Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Resolves #88.
Here is a test release: https://github.com/thomaseizinger/cargo-msrv/releases/tag/v0.7.3
Here is the workflow run that created it: https://github.com/thomaseizinger/cargo-msrv/actions/runs/1066616782
It is triggered on making a new release via Github.