Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new invitation params #20074

Merged
merged 10 commits into from
Sep 13, 2023
Merged

Add new invitation params #20074

merged 10 commits into from
Sep 13, 2023

Conversation

benhalpern
Copy link
Contributor

@benhalpern benhalpern commented Sep 8, 2023

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This feature adds the ability to customize the invitation email upon sending it — in order to give someone more context about the invitation.

It also includes style adjustments to the main invitation to make it a clear CTA.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

For more info, check out the
Forem Accessibility Docs.

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Uffizzi Preview deployment-35557 was deleted.

benhalpern and others added 2 commits September 11, 2023 07:11
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
app/models/user.rb ø
...controllers/concerns/api/admin/users_controller.rb 100.00%
app/mailers/devise_mailer.rb 100.00%

📢 Thoughts on this report? Let us know!.

benhalpern and others added 3 commits September 12, 2023 08:08
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@benhalpern benhalpern marked this pull request as ready for review September 12, 2023 12:41
@benhalpern benhalpern requested a review from a team as a code owner September 12, 2023 12:41
@benhalpern benhalpern requested review from lightalloy and rt4914 and removed request for a team September 12, 2023 12:41
@benhalpern benhalpern changed the title [Draft] Add new invitation params Add new invitation params Sep 12, 2023
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@benhalpern benhalpern merged commit a079434 into main Sep 13, 2023
@benhalpern benhalpern deleted the ben/add-fields-to-invitations branch September 13, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new params to invitations
3 participants