deployRecentValidation #389
Conversation
| * @param options.id = the deploy ID that's been validated already from a previous checkOnly deploy request | ||
| * @param options.rest = a boolean whether or not to use the REST API | ||
| */ | ||
| public async deployRecentValidation(options: recentValidationOptions): Promise<JsonCollection> { |
There was a problem hiding this comment.
I don't really know anything about this code base but it seems strange to me that this method would be inside connection.ts and the Connection class. Is this something all connections will need/use?
There was a problem hiding this comment.
It belongs in JSForce but we aren't going to put it there until we move over to v2. These will be removed in the v2 of core that uses v2 of jsforce. @WillieRuemmele can you put comments on these methods you are adding saying that, and that it is just to add the rest option for existing soap operations in jsforce.
| * @param options.id = the deploy ID that's been validated already from a previous checkOnly deploy request | ||
| * @param options.rest = a boolean whether or not to use the REST API | ||
| */ | ||
| public async deployRecentValidation(options: recentValidationOptions): Promise<JsonCollection> { |
There was a problem hiding this comment.
It belongs in JSForce but we aren't going to put it there until we move over to v2. These will be removed in the v2 of core that uses v2 of jsforce. @WillieRuemmele can you put comments on these methods you are adding saying that, and that it is just to add the rest option for existing soap operations in jsforce.
@W-9014822@
adds the
deployRecentValidationmethod to do a quick deploy with REST or SOAPcompare with https://github.com/salesforcecli/toolbelt/blob/main/src/lib/mdapi/mdApiUtil.ts#L36
and https://github.com/salesforcecli/toolbelt/blob/main/src/lib/mdapi/mdApiUtil.ts#L51