Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(salesforcedx-vscode): update node to v16 and npm v8 #4067

Closed
wants to merge 7 commits into from
Closed

build(salesforcedx-vscode): update node to v16 and npm v8 #4067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cbfd50a
build: switch package lock file to version 3
Apr 28, 2022
64fe2d5
ci: switch from node 14 to node 16
Apr 28, 2022
8ddafb5
build: disable strict peerDependencies that is default in npm8
Apr 28, 2022
24f06c3
build: refresh package lock file
Apr 28, 2022
6bbf3d0
refactor: use npm ci in reinstall script
Apr 28, 2022
3e4150b
Revert "refactor: use npm ci in reinstall script"
Apr 28, 2022
c36791f
build(debug): revert to package lock version 1 to check status on build
Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ parameters:
type: string
default: '3.13.1'
node-version:
# LTS 16.14 doesn't exist on legacy circle ci image https://hub.docker.com/r/circleci/node (Apr 2022)
type: string
default: '14.16.0'
default: '16.13'
# Constants
cache-version:
type: string
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-release-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: '14.16.x'
node-version: '16.13.x'
- name: Checkout
uses: actions/checkout@v2.0.0
with:
Expand Down
18 changes: 15 additions & 3 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
#save exact versions of dependencies from the package.json
# https://docs.npmjs.com/cli/v8/using-npm/config

# Save dependencies to package.json with an exact version rather than using npm's default semver range operator
save-exact=true

#enforces usage of the minimum node version in our .nvmrc
engine-strict=true
# Refuse to install (or even consider installing) any package that claims to not be compatible with the current Node.js version.
engine-strict=true


# Smaller on disk than lockfile version 2, but not interoperable with older npm versions. Ideal if all users are on npm version 7 and higher.
lockfile-version=1

# If a package cannot be installed because of overly strict peerDependencies that collide, it provides a way to move forward resolving the situation.
# TODO (debug):
# npm ERR! While resolving: salesforcedx-vscode-soql@54.8.0
# npm ERR! Found: @typescript-eslint/parser@3.10.1
legacy-peer-deps=true
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v14.16.0
v16.13.0
4 changes: 2 additions & 2 deletions contributing/developing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Pre-requisites

1. We are requiring Node 14 at a minimum. If you need to work with multiple versions of Node, you
1. We are requiring Node 16 at a minimum. If you need to work with multiple versions of Node, you
might consider using [nvm](https://github.com/creationix/nvm).
1. This repository uses [Lerna](https://lernajs.io/) to manage it as a
_monorepo_. Please install Lerna globally using `npm install --global lerna`.
Expand Down Expand Up @@ -205,4 +205,4 @@ The npmrc allows for project-level [configuration](https://docs.npmjs.com/cli/v8

### .nvmrc

Our nvmrc specifies the minimimum node version required to run the project.
Our nvmrc specifies the minimum node version required to run the project.
Loading