Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Drop custom tests for -apple- and -internal-prefixed properties #1133

Closed
wants to merge 1 commit into from

Conversation

foolip
Copy link
Owner

@foolip foolip commented Apr 29, 2021

These shouldn't be web exposed and it will hopefully be fixed:
#12 (comment)

These shouldn't be web exposed and it will hopefully be fixed:
#12 (comment)
Copy link
Contributor

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, currently the properties with "internal": true are:

['-webkit-font-size-delta',
 '-webkit-marquee-direction',
 '-webkit-marquee-increment',
 '-webkit-marquee-repetition',
 '-webkit-marquee-speed',
 '-webkit-marquee-style',
 '-webkit-mask-repeat-x',
 '-webkit-mask-repeat-y',
 'background-repeat-x',
 'background-repeat-y']

Comment on lines -4 to -5
"-apple-pay-button-style": {},
"-apple-pay-button-type": {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't internal (and are documented)

"-apple-color-filter": {},
"-apple-pay-button-style": {},
"-apple-pay-button-type": {},
"-apple-trailing-word": {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per https://bugs.webkit.org/show_bug.cgi?id=196575 this is deliberately supported (it's no-op, but remains because it's needed to avoid sending browser sniffing down the wrong codepath)

@@ -1,9 +1,5 @@
{
"properties": {
"-apple-color-filter": {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't internal, but should be disabled by default: https://bugs.webkit.org/show_bug.cgi?id=217802

@foolip
Copy link
Owner Author

foolip commented May 20, 2021

Testing https://mdn-bcd-collector.appspot.com/tests/css/properties in Safari 14.1 all of these are in fact still web exposed, so let's just keep the tests for them then. I'm skeptical that they should all be added to MDN/BCD, but that's a separate problem from generating the tests.

@foolip foolip closed this May 20, 2021
@foolip foolip deleted the apple-internal branch May 20, 2021 12:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants