Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): format LESS files using official prettier #2669

Merged
merged 7 commits into from
Apr 10, 2023
Merged

feat(ci): format LESS files using official prettier #2669

merged 7 commits into from
Apr 10, 2023

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jan 20, 2023 •
edited
Loading

@mvorisek mvorisek changed the title Format LESS files using unpatched prettier Format LESS files using official/unpatched prettier Jan 20, 2023
@mvorisek mvorisek force-pushed the prettier_unpatched branch 2 times, most recently from da4bb2e to abf6f8f Compare January 20, 2023 18:36
@mvorisek mvorisek changed the title Format LESS files using official/unpatched prettier Format LESS files using official prettier Mar 26, 2023
@mvorisek mvorisek marked this pull request as ready for review April 9, 2023 09:54
@mvorisek mvorisek marked this pull request as draft April 9, 2023 09:55
@mvorisek mvorisek marked this pull request as ready for review April 10, 2023 09:43
@mvorisek
Copy link
Contributor Author

@lubber-de prettier/prettier#14208 was merged, but not sure when the next release will be...

Are you ok to merge this PR now using the commit reference?

Later, it can be replaced with a stable version.

Also, I have archived https://github.com/fomantic/prettier and the repo can be deleted in the future.

@lubber-de lubber-de added type/feat Any feature requests or improvements type/chore Anything which is a project chore labels Apr 10, 2023
@lubber-de lubber-de added this to the 2.9.3 milestone Apr 10, 2023
@lubber-de lubber-de changed the title Format LESS files using official prettier feat(ci): format LESS files using official prettier Apr 10, 2023
@lubber-de lubber-de merged commit 721a6c3 into fomantic:develop Apr 10, 2023
@mvorisek mvorisek deleted the prettier_unpatched branch April 10, 2023 18:52
@lubber-de lubber-de mentioned this pull request Dec 15, 2024
Merged
lubber-de added a commit that referenced this pull request Dec 20, 2024
@lubber-de
feat(ci): upgrade to prettier v3
7446b46 
Switch Lint CI check for prettier to latest official stable version v3. Everything fixed via #2669 seems to be included in prettier@3 since quite a while now, so no need to stay at a fixed commit anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@ko2in ko2in Awaiting requested review from ko2in

@lubber-de lubber-de Awaiting requested review from lubber-de

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
type/chore Anything which is a project chore type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.9.3
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @lubber-de