test: 🚨 don't trigger --build during runner tests

folke · Mar 4, 2020 · c4a2db3 · c4a2db3
1 parent fbfa5b7
commit c4a2db3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 17 deletions.
diff --git a/__tests__/runner-spawn.ts b/__tests__/runner-spawn.ts
@@ -1,10 +1,8 @@
-import { HASH_FILE } from "./../src/build"
-import fs from "fs"
-import { Runner } from "../src/runner"
-import sinon from "sinon"
 import chai from "chai"
-import sinonChai from "sinon-chai"
 import chalk from "chalk"
+import sinon from "sinon"
+import sinonChai from "sinon-chai"
+import { Runner } from "../src/runner"
 
 chai.use(sinonChai)
 chai.should()
@@ -20,7 +18,7 @@ chalk.level = 0
 
 beforeEach(() => {
   sinon.resetHistory()
-  if (fs.existsSync(HASH_FILE)) fs.unlinkSync(HASH_FILE)
+  // if (fs.existsSync(HASH_FILE)) fs.unlinkSync(HASH_FILE)
 })
 
 afterAll(() => {

diff --git a/__tests__/runner.ts b/__tests__/runner.ts
@@ -1,13 +1,11 @@
-import { HASH_FILE } from "./../src/build"
 import chai from "chai"
 import chalk from "chalk"
-import fs from "fs"
 import * as path from "path"
 import sinon from "sinon"
 import sinonChai from "sinon-chai"
 import { defaults } from "../src/options"
-import { Runner } from "../src/runner"
 import { PackageJson } from "../src/package"
+import { Runner } from "../src/runner"
 
 chai.use(sinonChai)
 chai.should()
@@ -24,7 +22,7 @@ chalk.level = 0
 
 beforeEach(() => {
   sinon.resetHistory()
-  if (fs.existsSync(HASH_FILE)) fs.unlinkSync(HASH_FILE)
+  // if (fs.existsSync(HASH_FILE)) fs.unlinkSync(HASH_FILE)
 })
 
 afterAll(() => {
@@ -35,9 +33,9 @@ afterAll(() => {
 const advancedPackage: PackageJson = {
   name: "advanced-package",
   scripts: {
-    prebuild: "yarn clean && yarn lint && yarn test",
+    prebuildit: "yarn clean && yarn lint && yarn test",
     "build:rollup": "npx rollup -c",
-    build: "yarn build:rollup",
+    buildit: "yarn build:rollup",
     clean: "npx rimraf lib",
     test: "npx jest",
     lint: "yarn lint:ts && yarn lint:eslint && yarn lint:docs",
@@ -53,16 +51,16 @@ test("constructor", () => {
 
 test("advanced build --dry-run", async () => {
   const runner = new Runner({ dryRun: true })
-  await runner.run("build", advancedPackage)
+  await runner.run("buildit", advancedPackage)
   chai.expect(stubs.spawn).not.to.be.called
 })
 
 test("advanced build --no-pretty", async () => {
   const runner = new Runner()
-  await runner.run("build", advancedPackage)
+  await runner.run("buildit", advancedPackage)
 
   stubs.log.should.be.calledWith("❯ lint")
-  stubs.log.should.be.calledWith("❯ prebuild")
+  stubs.log.should.be.calledWith("❯ prebuildit")
   stubs.log.should.be.calledWith("❯ clean")
 
   stubs.spawn.should.be.callCount(6)
@@ -106,7 +104,7 @@ test("advanced build --no-pretty", async () => {
 
 test("advanced build --pretty", async () => {
   const runner = new Runner({ pretty: true })
-  await runner.run("build", advancedPackage)
+  await runner.run("buildit", advancedPackage)
 
   stubs.write.should.be.calledWithMatch("✔")
 
@@ -151,7 +149,7 @@ test("advanced build --pretty", async () => {
 
 test("advanced build --raw", async () => {
   const runner = new Runner({ raw: true })
-  await runner.run("build", advancedPackage)
+  await runner.run("buildit", advancedPackage)
 
   stubs.spawn.should.be.callCount(6)
   stubs.spawn