UIU-3347 bump jspdf to v3.0.0 #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses security vulnerability within jspdf <3 dependencies.
zburke
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
Code changes LGTM. I'm glad you noticed the jspdf-autotable API change! 🕵️
@s3fs, no, this does not require a major version bump. Changing direct (internal) dependencies does not change the public (external) API either in terms of what is consumed (peer-dependencies, okapi interfaces) or what is provided (public exports, routes, etc).
- Yes, we should add a CHANGELOG entry, describing why we made these changes.
- @JohnC-80, let's generate
yarn.lockfrom scratch (rm yarn.lock; yarn install) to de-duplicate things likedompurify. Since deps are ultimately resolved at the platform level this doesn't really matter, but it should help keep dependabot off our backs for a little while longer by purging some cruft (e.g. paringdompurifydown to a single, current version instead of installing three, two of which are outdated).
zburke
approved these changes
Mar 18, 2025
s3fs
approved these changes
Mar 19, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIU-3347
Addresses security vulnerability within
jspdf< 3 dependencies.This also updates
jspdf-autotableplug-in to v5Noteworthy changes for the autotable plugin -
doc.autotable.previousapi replaced bydoc.lastAutoTable.titlekey in columns object renamed toheader.Output pdf:
